Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems during re-visualization #585

Open
djnemeth opened this issue Apr 15, 2018 · 0 comments · May be fixed by #614
Open

Problems during re-visualization #585

djnemeth opened this issue Apr 15, 2018 · 0 comments · May be fixed by #614

Comments

@djnemeth
Copy link
Member

If one tries to re-visualize a model for which there is an already existing Papyrus diagram in the project's gen folder, the visualization fails. If the corresponding diagram is opened during re-visualization, a ConcurrentModificationException occurs and the gen folder has to be cleaned. Otherwise the process seemingly succeeds, but in reality, only the .di and .notation files disappear from the gen folder. In this case, however, a second re-visualization attempt actually creates and opens the correct diagram. This is only for Papyrus – JS works as intended, but it could be improved too.

It would be great if

  1. Papyrus diagrams could be re-visualized without the need of cleaning gen, whether the previously generated diagram is opened or not – here we could simply overwrite the existing diagram;
  2. the user could decide whether they wants to overwrite the existing diagram or cancel the visualization – this is for both Papyrus and JS.

It would be even greater if we could append "tabs" to existing diagrams. For example, if one visualizes a class diagram from a model in Papyrus and then decides to add a state machine diagram from the same model, we wouldn't need to replace the whole .di file, but simply append the new diagram to the existing one. The same for JS. As this doesn't look like a trivial task, I'm willing to create a separate issue for it.

@szokolai-mate szokolai-mate self-assigned this Apr 15, 2018
szokolai-mate added a commit that referenced this issue Apr 19, 2018
 - fixed the Papyrus visualization failure when there is already a "gen" folder present
    - the problem was solved by refreshing the folder after cleanup
 - reduced cleanup code duplication in `TxtUMLVisualizeWizard` and it's children (#582)
@djnemeth djnemeth added this to In Development in Visualization Apr 26, 2018
szokolai-mate added a commit that referenced this issue May 3, 2018
Refactoring of components involved in the visualization process.

Solves:
	- #585 (bug only)
	- #582
	- #577
@djnemeth djnemeth moved this from In Development to Pull Request in Visualization Jun 19, 2018
@djnemeth djnemeth moved this from Pull Request to In Development in Visualization Jun 27, 2018
@szokolai-mate szokolai-mate linked a pull request Nov 24, 2018 that will close this issue
@djnemeth djnemeth moved this from In Development to Pull Request in Visualization Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Visualization
Pull Request
Development

Successfully merging a pull request may close this issue.

2 participants