Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same shape #13

Merged
merged 4 commits into from
Aug 1, 2017
Merged

Same shape #13

merged 4 commits into from
Aug 1, 2017

Conversation

ELToulemonde
Copy link
Owner

@ELToulemonde ELToulemonde commented Jul 31, 2017

New feature:

  • sameShape to give the same shape at two data set, for exemple give your test set the same shape as train set.
  • some minor bug fix

  • enhancement: more dates formats tested (especialy hours)

  • better code coverage (on old files)

New feature:
- same shape: make two data set have the exact same shape
- New dates formats accepted

Bug fix:
- Error on log for shapeSet
change typo and it's consequences
@ELToulemonde ELToulemonde self-assigned this Jul 31, 2017
@ELToulemonde ELToulemonde added this to Other new features ideas in New features Jul 31, 2017
@codecov
Copy link

codecov bot commented Jul 31, 2017

Codecov Report

Merging #13 into master will decrease coverage by 0.12%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   99.45%   99.32%   -0.13%     
==========================================
  Files          10       11       +1     
  Lines        1098     1193      +95     
==========================================
+ Hits         1092     1185      +93     
- Misses          6        8       +2
Impacted Files Coverage Δ
R/whichFunctions.R 100% <100%> (ø) ⬆️
R/shapeSet.R 100% <100%> (ø) ⬆️
R/setColAs.R 99.23% <100%> (ø) ⬆️
R/numericsManipulations.R 100% <100%> (+1.21%) ⬆️
R/datesManipulations.R 98.79% <71.42%> (ø) ⬆️
R/sameShape.R 96.77% <96.77%> (ø)
R/prepareSet.R 97.77% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbf19f...4bf66a2. Read the comment docs.

+ better unit test
+ change on hours manipulations
@ELToulemonde ELToulemonde merged commit 423b912 into master Aug 1, 2017
@ELToulemonde ELToulemonde deleted the Same-shape branch August 1, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
New features
Other new features ideas
Development

Successfully merging this pull request may close these issues.

None yet

1 participant