Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtering chapter list by TL language doesn't work #8

Closed
typhoon71 opened this issue Aug 22, 2021 · 3 comments
Closed

filtering chapter list by TL language doesn't work #8

typhoon71 opened this issue Aug 22, 2021 · 3 comments
Assignees

Comments

@typhoon71
Copy link

typhoon71 commented Aug 22, 2021

Describe the bug
filtering chapter list by TL language doesn't work, you get a 400 response

To Reproduce
import mangadex

import mangadex

api = mangadex.Api()
chapter_list = api.chapter_list(manga="30196491-8fc2-4961-8886-a58f898b1b3e", chapter=35, limit=20, translatedLanguage='en')

Expected behavior
get only the chapter translated in ''en"

The call works fine till I add translatedLanguage='en'; "translatedLanguage" should be a valid parameter.
Passig translatedLanguage=['en'] doesn't solve it (the is Array of strings, so I tried but no dice).

bw: awesome work, I wanted to do some mangadex-API to python3 myself, but this is just right for me.

@EMACC99 EMACC99 added the bug Something isn't working label Aug 22, 2021
@EMACC99 EMACC99 self-assigned this Aug 22, 2021
@EMACC99
Copy link
Owner

EMACC99 commented Aug 23, 2021

I looked into it and discovered I was not parsing some parameters correctly, I just made some changes and saw that many other functions have this issue too. It was my bad for overlooking this issue but it should be fixed by now. I still need to create the release, but you can clone the repo and install it with setup.py if you want. Also if you encounter any other issues, please let me know.

@typhoon71
Copy link
Author

Thanks a lot, I will test this as soon I get a bit of time, this weekend I suppose.

@typhoon71
Copy link
Author

Played around a bit before going to bed and spotted something: I think "sacanlation_group_id" should be "scanlation_group_id", as it's in mangadex API.

More serious testing later as I said, but seems good to me.

@EMACC99 EMACC99 removed the bug Something isn't working label Aug 24, 2021
@EMACC99 EMACC99 closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants