Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 1 fails when there is no tty #287

Closed
adrianmo opened this issue Jun 23, 2017 · 2 comments
Closed

Step 1 fails when there is no tty #287

adrianmo opened this issue Jun 23, 2017 · 2 comments
Assignees
@adrianmo
Labels
bug
Milestone
Install Node 2.3.0

Comments

@adrianmo
Copy link
Contributor

Step 1 script fails when there is no TTY in the device running the script.

the input device is not a tty

Removing the -t from the docker run command in the run.sh file may fix the issue. I will give it a try and submit a PR.
@adrianmo adrianmo added the bug label Jun 23, 2017
@adrianmo adrianmo self-assigned this Jun 23, 2017
@padthaitofuhot
Copy link
Contributor

@adrianmo What I want is to detect whether we have a TTY or not and then change the flag accordingly. When running under a TTY I absolutely want to have the -t flag present on the docker run command line.

@adrianmo
Copy link
Contributor Author

@padthaitofuhot OK, I can confirm that the issue was fixed by removing the -t flag. We can leave this open until we implement that TTY detection.

@padthaitofuhot padthaitofuhot added this to Milestone 2.3.0 To-Do in Installer 2.x Jun 23, 2017
@padthaitofuhot padthaitofuhot moved this from Milestone 2.3.0 To-Do to Current Milestone In-Progress in Installer 2.x Jun 23, 2017
@padthaitofuhot padthaitofuhot added this to the Install Node 2.3.0 milestone Jun 26, 2017
@padthaitofuhot padthaitofuhot mentioned this issue Jun 28, 2017
Merged
padthaitofuhot added a commit that referenced this issue Jun 28, 2017
@padthaitofuhot
Resolves #287: Step 1 fails when there is no tty (#298)
7031af2 
* Add shell shim path to PATH in .bashrc also

* Add tty context detection

* select '-it' in docker run/exec based on TTY presence

* keep -i no matter what.
@padthaitofuhot padthaitofuhot mentioned this issue Jul 13, 2017
Merged
3 tasks
@padthaitofuhot padthaitofuhot moved this from Current Milestone In-Progress to Done in Installer 2.x Jul 13, 2017
@padthaitofuhot padthaitofuhot removed this from Done in Installer 2.x Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianmo adrianmo

Labels
bug
Projects
None yet
Milestone
Install Node 2.3.0
Development

No branches or pull requests
2 participants
@adrianmo @padthaitofuhot