Add warning to VDC keystore update method

EMCECS · Sep 26, 2017 · 0231f84 · 0231f84
1 parent 6d20dd4
commit 0231f84
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ecsclient/common/provisioning/vdc_keystore.py b/ecsclient/common/provisioning/vdc_keystore.py
@@ -30,6 +30,8 @@ def get(self):
     def set(self, private_key, certificate_chain):
         """
         Set the private key and certificate chain being used by ECS.
+        WARNING: Note that the certificate will not be updated until ECS is
+        restarted. Restarting ECS is out of the scope of this library.
 
         Required role(s):
 
@@ -51,5 +53,6 @@ def set(self, private_key, certificate_chain):
           }
         }
 
-        log.info("Setting the private key and certificate chain")
+        log.info("Setting the private key and certificate chain (ECS must be "
+                 "restarted for this change to take effect)")
         return self.conn.put('vdc/keystore', json_payload=payload)
diff --git a/tests/functional/test_vdc_keystore.py b/tests/functional/test_vdc_keystore.py
@@ -14,5 +14,6 @@ def test_vdc_keystore_set(self):
         certificate = helper.get_sample_certificate()
         response = self.client.vdc_keystore.set(private_key, certificate)
         self.assertValidSchema(response, schemas.VDC_KEYSTORE)
-        # TODO: Find out why the returned certificate different
+        # Can't validate the certificate and private key at this point
+        # because it does not take effect until the ECS is manually restarted
         # self.assertSameCertificate(certificate, response['chain'])