Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte@4 - compilerOptions.css as a boolean is deprecated #185

Closed
Valexr opened this issue Jun 26, 2023 · 3 comments
Closed

svelte@4 - compilerOptions.css as a boolean is deprecated #185

Valexr opened this issue Jun 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Valexr
Copy link

Valexr commented Jun 26, 2023

Describe the bug
compilerOptions.css as a boolean is deprecated. Use 'external' instead of false.

To Reproduce
Any compilations

Expected behavior
Use 'external' instead of false.

  • esbuild-svelte version: latest
  • esbuild version: latet
  • Svelte preprocessors used (if any): yes
@Valexr Valexr added the bug Something isn't working label Jun 26, 2023
@EMH333 EMH333 changed the title ⚠️ svelte@4 - compilerOptions.css as a boolean is deprecated svelte@4 - compilerOptions.css as a boolean is deprecated Jun 26, 2023
@EMH333
Copy link
Owner

EMH333 commented Jun 26, 2023

Svelte v4 support hasn't been verified yet for esbuild-svelte (I should have tightened the version locks). Thanks for the report and I should have it resolved later this week!

@Valexr
Copy link
Author

Valexr commented Jun 26, 2023

So far, it's just a warning. Maybe later will be as deprecated error…

EMH333 added a commit that referenced this issue Jun 26, 2023
@EMH333
Set css option to external when using Svelte v4+
90f7258 
In reference to #185
@EMH333
Copy link
Owner

EMH333 commented Jun 27, 2023

Fixed in esbuild-svelte@0.7.4

@EMH333 EMH333 closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Valexr @EMH333