Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate error and warning codes for Svelte 5 support (including in tests) #232

Open
Greenheart opened this issue May 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Greenheart
Copy link

Describe the bug

This is related my comment in #230 about finding out that we likely need to upgrade the compiler + tests to svelte 5. It's good to know that the error + warning codes have changed the separator from - to _.

More details:
https://svelte-5-preview.vercel.app/docs/breaking-changes#other-breaking-changes-error-warning-codes-have-been-renamed

@Greenheart Greenheart added the bug Something isn't working label May 17, 2024
@Greenheart
Copy link
Author

The warning missing-declaration seems to have been removed in Svelte 5

For Svelte 5, searching for missing in this page, there is no match: https://github.com/sveltejs/svelte/blob/main/packages/svelte/src/compiler/warnings.js

For Svelte 4, the warning still exists
https://github.com/sveltejs/svelte/blob/d04c146b4649e47d4cb86a93cfa33b910a229591/packages/svelte/src/compiler/compile/compiler_warnings.js#L30

This probably means we need to update the test case checking for this removed compiler warning, and instead trigger another warning. Then we can preserve the intention of the test, but not rely on the changed compiler output in Svelte 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant