Update compiler, tests and examples to use Svelte 5 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
EMH333
reviewed
May 18, 2024
| @@ -202,7 +201,7 @@ export default function sveltePlugin(options?: esbuildSvelteOptions): Plugin { | |||
| dependencyModifcationTimes.set(args.path, statSync(args.path).mtime); // add the target file | |||
|
|
|||
| let compilerOptions = { | |||
| css: (svelteVersion < 3 ? false : "external") as boolean | "external", | |||
| css: (svelteVersion < 3 ? undefined : "external") as CompileOptions["css"], | |||
There was a problem hiding this comment.
After looking at this a bit more, I'm fairly sure this logic is broken for everything between Svelte 3.43.0 and 3.53.0 (when support for "external" was added). And actually, false is never returned at all since the version lock requires Svelte >3.43.0. Fun.
Probably not a huge deal, but all the more reason to tear it out soon!
|
Whoops! Could you reopen or create a new PR pointing at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on findings in #230 (review).
Updating the main devDependencies in
package.jsonto Svelte 5 and re-building the plugin was what I needed to get my app to build properly with Svelte 5.Also updated tests to work for Svelte 5, as well as type errors in the plugin (due to changed imports and compiler options) and finally updated examples to show usage with Svelte 5 (since mounting a Svelte component will be a breaking change compared to Svelte 4).
fixes #232