Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand pint requirements to include more versions #150

Merged
merged 3 commits into from Nov 7, 2023

Conversation

francescalb
Copy link
Contributor

@francescalb francescalb commented Nov 7, 2023

Description:

The tests on github work both with pint==0.16.1 and with the latest version.
I have therefore set up the whole range as acceptable for now.
Thie is needed as tripper is being used by programs that use pint 0.16.1 (OntoFlow and the QuantumEspresso plugin for Aiida/ExecFlow)

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad90cc1) 75.08% compared to head (8af90b1) 75.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   75.08%   75.08%           
=======================================
  Files          17       17           
  Lines        1405     1405           
=======================================
  Hits         1055     1055           
  Misses        350      350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@francescalb francescalb marked this pull request as ready for review November 7, 2023 14:01
@francescalb francescalb merged commit f799a29 into master Nov 7, 2023
14 checks passed
@francescalb francescalb deleted the pint_dependency_range branch November 7, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants