Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrate_yaw.cfg should be renamed to imu.cfg #21

Closed
KristofRobot opened this issue Feb 23, 2015 · 0 comments
Closed

calibrate_yaw.cfg should be renamed to imu.cfg #21

KristofRobot opened this issue Feb 23, 2015 · 0 comments

Comments

@KristofRobot
Copy link
Collaborator

According to http://wiki.ros.org/dynamic_reconfigure/Tutorials/HowToWriteYourFirstCfgFile, https://github.com/KristofRobot/razor_imu_9dof/blob/indigo-devel/config/calibrate_yaw.cfg has an issue:

NOTE: The third parameter should be equal to the cfg file name, without extension. Otherwise the libraries will be generated in every build, forcing a recompilation of the nodes which use them. 

I.e. we should either rename the cfg file to imu.cfg - or change following:

exit(gen.generate(PACKAGE, "razor_imu_9dof", "calibrate_yaw"))

I also think we should move this file to a cfg directory, rather than config, which is meant for yaml configuration files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant