Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes contractor drop pods not being clickable due to suspected BYOND…
… issue. (tgstation#61723) Fixes tgstation#61695 When breaking the entire problem down, I identified the point in time at which the pod stopped being clickable Spawning in pods manually and running their various procs couldn't replicate the issue. As a result, I eliminated pod code as the root cause and focused on the pod_landingzone that control them. I considered the debris as a possible cause following: tgstation#61695 However, removing the debris actually removed ALL clickable area for the pods. The debris overlap was the only part that let me click on the pods. So then I set to hacking away at any animation code. At one point I removed both the animates animate(pod.get_filter("motionblur"), y = 0, time = pod.delays[POD_FALLING], flags = ANIMATION_PARALLEL) animate(pod, pixel_z = -1 * abs(sin(rotation))*4, pixel_x = SUPPLYPOD_X_OFFSET + (sin(rotation) * 20), time = pod.delays[POD_FALLING], easing = LINEAR_EASING, flags = ANIMATION_PARALLEL) //Make the pod fall! At an angle! from /obj/effect/pod_landingzone/proc/beginLaunch and the problem still persisted. When I removed pod.add_filter("motionblur",1,list("type"="motion_blur", "x"=0, "y"=3)) after this (the effect was permanently on the pod which made it pretty obvious as a possible cause) the problem vanished entirely. Without the motion blur filter applied, pods now function properly. As a result, I believe this is a BYOND issue. Someone with more brains than me can probably work out a test case. Until someone with more brains than me comes along to fix it, removing the motion blur filter is my solution.
- Loading branch information