Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved search functionality #289

Merged
merged 4 commits into from Nov 12, 2022
Merged

Improved search functionality #289

merged 4 commits into from Nov 12, 2022

Conversation

codetheorem
Copy link
Member

@codetheorem codetheorem commented Nov 1, 2022

Signed-off-by: Hrishikesh Agarwal hrishikeshagarwal@Hrishikeshs-MacBook-Air.local

Issue Number

fixes #

Describe the changes you've made

I have updated the search functionality now user does not require to select title or author. The application will first search for users and then for titles. It improves user experience.

Test plan (OPTIONAL)

1.Search for any story on the home page.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Preview: Deploy preview link here with the appropriate route

Signed-off-by: Hrishikesh Agarwal <hrishikeshagarwal@Hrishikeshs-MacBook-Air.local>
@cyntss
Copy link
Member

cyntss commented Nov 11, 2022

When I look for a story it can't find it and the message is "User not found"

image

Hrishikesh Agarwal and others added 2 commits November 11, 2022 23:39
Signed-off-by: Hrishikesh Agarwal <hrishikeshagarwal@Hrishikeshs-MacBook-Air.local>
@codetheorem
Copy link
Member Author

When I look for a story it can't find it and the message is "User not found"

image

I have now changed this if there is no user then it will not show dropdown.

Signed-off-by: Hrishikesh Agarwal <hrishikeshagarwal@Hrishikeshs-Air.mshome.net>
@cyntss cyntss merged commit 564ea3e into main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants