Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Convert assert() into throwing exceptions in WAVM and BINARYEN #3498

Closed
bytemaster opened this issue May 28, 2018 · 1 comment
Closed

Convert assert() into throwing exceptions in WAVM and BINARYEN #3498

bytemaster opened this issue May 28, 2018 · 1 comment
Assignees
@tbfleming
Milestone
Version 1.0

Comments

@bytemaster
Copy link
Contributor

If any of these asserts trigger in release it shouldn't pass, but should throw. Allowing the code to continue running in release is a potential security vulnerability and will likely result in crashes elsewhere.
@bytemaster bytemaster added this to the Version 1.0 milestone May 28, 2018
@bytemaster bytemaster assigned moskvanaft and tbfleming and unassigned moskvanaft May 28, 2018
@tbfleming tbfleming mentioned this issue May 28, 2018
Merged
tbfleming added a commit that referenced this issue May 28, 2018
@tbfleming
convert wavm asserts into throw #3498
e8c2d66
tbfleming added a commit that referenced this issue May 28, 2018
@tbfleming
convert binaryen asserts into throw #3498
3bdf8db
bytemaster added a commit that referenced this issue May 28, 2018
@bytemaster
Merge pull request #3506 from EOSIO/wavm-assert
1aa3fdd 
Convert assert into throw in binaryen and wavm #3498
moskvanaft added a commit that referenced this issue May 28, 2018
@moskvanaft
don't fall into forever loop in zero byty in json #3498
010f3f4
@CodyDeeds
Copy link
Contributor

bitmoji

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbfleming tbfleming

Labels
None yet
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
4 participants
@bytemaster @tbfleming @CodyDeeds @moskvanaft