This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
implement splitting/extracting block log for eosio_blocklog #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation related comments:
Or does this tool strictly work only with the full block.log file? |
So far, it only works with full block.log file. For more complex stride adjusting, it should be implemented as script instead of in the eosio_blocklog tool. |
brianjohnson5972
suggested changes
Feb 15, 2021
libraries/chain/block_log.cpp
Outdated
| EOS_ASSERT(start_block_num >= log_bundle.log_data.first_block_num(), block_log_exception, | ||
| "The first available block is block ${first_block}.", ("first_block", log_bundle.log_data.first_block_num())); | ||
|
|
||
| EOS_ASSERT(start_block_num + num_blocks -1 <= log_bundle.log_data.last_block_num(), block_log_exception, |
libraries/chain/block_log.cpp
Outdated
| for (uint32_t i = first_block_num / stride; | ||
| i < last_block_num / stride + 1; ++i) { | ||
| uint32_t start_block_num = std::max(i * stride + 1, first_block_num); | ||
| uint32_t num_blocks = std::min(stride, last_block_num - start_block_num + 1); |
There was a problem hiding this comment.
I think you need to start this loop with a little more complexity, if stride=1000, first_block_num=999, and last_block_num=2000 we will have
i=0 => start_block_num=999, num_blocks=1000
i=1 => start_block_num=1001, num_blocks=1000
i=2 => start_block_num=2001, num_blocks=0
There was a problem hiding this comment.
You were looking at outdated code
brianjohnson5972
approved these changes
Feb 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
implement splitting/extracting block log for eosio_blocklog
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions
eosio_blocklogadded two new options