Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Fix docker steps on tagged builds. #10064

Merged
merged 2 commits into from Feb 18, 2021

Conversation

scottarnette
Copy link
Contributor

Change Description

Logic that required a tagged build to function was finally exercised and exposed some errors when building eosio containers.

  • Fixed incorrect tagging step to use BUILD_TAG instead of defaulting to latest.
  • Add missing push step before removing the tag.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@kj4ezj kj4ezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@scottarnette scottarnette merged commit 8ec6900 into develop Feb 18, 2021
@scottarnette scottarnette deleted the sa/fix-docker-publish-tags-dev branch February 18, 2021 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants