Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

don't specify default values for reversible blocks db configs #10298

Merged
merged 1 commit into from Apr 27, 2021

Conversation

spoonincode
Copy link
Contributor

Change Description

Specifying default values for these makes nodeos always print

warn  2021-04-27T14:17:13.669 nodeos.Ma chain_plugin.cpp:875          plugin_initialize    ] reversible-blocks-db-size-mb deprecated and will be removed in future version
warn  2021-04-27T14:17:13.669 nodeos.Ma chain_plugin.cpp:878          plugin_initialize    ] reversible-blocks-db-guard-size-mb deprecated and will be removed in future version

on start up, even if the user didn't set them. Removing the default value means they're only printed if the user has actually set the config, which I think is more in line with the intention?

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@spoonincode spoonincode merged commit 049b601 into develop Apr 27, 2021
@spoonincode spoonincode deleted the no_default_reversibledb branch April 27, 2021 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants