Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Big ship deltas - 2.0 #11051

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Big ship deltas - 2.0 #11051

merged 4 commits into from
Jan 28, 2022

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Jan 27, 2022

Change Description

eosnetworkfoundation/mandel#24

Fix for deltas bigger than uint32_t size can indicate. This was hit on Wax.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@huangminghuang huangminghuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the disk format of the ship log and we should also change the ship_current_version value. However, ship_current_version=1 is already taken, I am not exactly sure which version we should use here.

@tbfleming
Copy link
Contributor

On Mandel, I'm leaning against bumping the version. As long as the size isn't exceeded, it's backwards compatible. If it is exceeded, boost will try to decompress an empty stream. If boost throws, it will disconnect the client. If boost returns an empty stream, the client will receive an empty stream and fail to deserialize, indicating a problem.

@heifner heifner merged commit 173261f into release/2.0.x Jan 28, 2022
@heifner heifner deleted the big-ship-deltas-2.0 branch January 28, 2022 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants