This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add bnet support to launcher #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiszczak
reviewed
May 25, 2018
| @@ -989,10 +1016,18 @@ launcher_def::write_config_file (tn_node_def &node) { | |||
|
|
|||
| if(!is_bios) { | |||
| auto &bios_node = network.nodes["bios"]; | |||
| cfg << "p2p-peer-address = " << bios_node.instance->p2p_endpoint<< "\n"; | |||
| if (p2p == p2p_plugin::NET) { | |||
There was a problem hiding this comment.
In keeping with the net_plugin default, shouldn't this be reversed? Specific to p2p_plugin::BNET, otherwise anything else gets the other setting.
There was a problem hiding this comment.
IRL discussion occurred and this is okay.
jgiszczak
approved these changes
May 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option --p2p-plugin that accepts values of "net" and "bnet" and defines the p2p plugin to use. At this point it is an either-or option and does not support mixed networks.