This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Voted back in Producer Watermark fix #4559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... But there appears to be no way to query this beyond waiting for a tricky error message from one of the find/add APIs??? For now just use the model number of the system which of coruse is totally bogus and fragile
…ts-2 Integration test improvements
Fix one code scope issue in `net_plugin`
…initializing producer accounts. Add port availability check.
Add sanity test for ensuring basic setup.
Merging master
Cleos get account bug fixes
Merging release/1.1 into eosio_build_darwin
Merging release/1.1 into eosio_build_ubuntu
…ion. Added special return code and output for dirty flag exception when wrapped in a fc::exception.
Fix for EOSIO#4178 [skip-ci]
Ubuntu build: Upgraded MongoDB C & Cxx drivers
fix ignore ipv6
Producerlag
Gh#3030 enable mongodb
…o_variant_with_abi.
… serializer deadline.
Refactor max_serialization_time to be passed as argument instead
|
@wanderingbort can you verify the change in producer_plugin.cpp? I am using generate_next and maybe_promote_schedule because when I used next(...) passing in a fabricated header, there were odd problems, so I only did the minimal parts to get the schedule to promote. @heifner can you review the test changes and new test? I will do more cleanup and additions later, just wanted to get in a test that would cause this problem to exhibit if it were still present. |
|
Something went wrong, closing and resubmitting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 3835
Moved watermark code to on_block and to check if the future block would result in the schedule changing to prevent causing a producer from dropping a block when it was put back in the production schedule after being removed a long time in the past.
Added initial long running test for voting that exposed this problem.