New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print config.ini & data-dir nodeos is using at launch #6222

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@spoonincode
Contributor

spoonincode commented Nov 2, 2018

Change Description
Instead of printing the "eosio root" when nodeos starts, print the config.ini used and the data directory used. The "eosio root" is the same no matter the --config-dir and --data-dir options which can make it deceptive on the actual config.ini used. This will make it a little easier to help users know what file is being used for configuration

Consensus Changes
none

API Changes
none

Documentation Additions
none

@heifner

heifner approved these changes Nov 5, 2018

@heifner heifner merged commit 7e003b2 into release/1.4.x Nov 5, 2018

20 checks passed

buildkite/eosio Build #5398 passed (34 minutes, 3 seconds)
Details
buildkite/eosio/aws-build Passed (10 minutes, 14 seconds)
Details
buildkite/eosio/aws-np-tests Passed (10 minutes, 45 seconds)
Details
buildkite/eosio/aws-tests Passed (7 minutes, 19 seconds)
Details
buildkite/eosio/centos-build Passed (12 minutes, 28 seconds)
Details
buildkite/eosio/centos-np-tests Passed (12 minutes, 22 seconds)
Details
buildkite/eosio/centos-tests Passed (7 minutes, 20 seconds)
Details
buildkite/eosio/darwin-build Passed (8 minutes, 24 seconds)
Details
buildkite/eosio/darwin-np-tests Passed (21 minutes, 17 seconds)
Details
buildkite/eosio/darwin-tests Passed (8 minutes, 45 seconds)
Details
buildkite/eosio/fedora-build Passed (11 minutes, 54 seconds)
Details
buildkite/eosio/fedora-np-tests Passed (10 minutes, 8 seconds)
Details
buildkite/eosio/fedora-tests Passed (6 minutes, 58 seconds)
Details
buildkite/eosio/pipeline Passed (4 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-build Passed (7 minutes, 51 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-np-tests Passed (10 minutes, 7 seconds)
Details
buildkite/eosio/ubuntu-18-dot-04-tests Passed (7 minutes, 33 seconds)
Details
buildkite/eosio/ubuntu-build Passed (9 minutes, 14 seconds)
Details
buildkite/eosio/ubuntu-np-tests Passed (10 minutes, 33 seconds)
Details
buildkite/eosio/ubuntu-tests Passed (7 minutes, 30 seconds)
Details

@heifner heifner deleted the print_nodeos_config_path branch Nov 5, 2018

wanderingbort added a commit that referenced this pull request Nov 6, 2018

Revert "Merge pull request #6222 from EOSIO/print_nodeos_config_path"
This reverts commit 7e003b2, reversing
changes made to e0cb96c.

these changes will be re-applied to the `develop` branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment