Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Clean up wasm cache entries based on irreversibility & fix wavm module cleanup #6983

Closed
wants to merge 2 commits into from
Closed

Clean up wasm cache entries based on irreversibility & fix wavm module cleanup #6983

wants to merge 2 commits into from

Commits on Mar 22, 2019

  1. Destroy wavm module instances when deleting the wavm_instantiated_module 

    When we instantiate a wasm with wavm we get back a ModuleInstance. But deleting this object is a noop because wavm has its own garpage collection thing. Implement the code to interface with the garbage collection so that deleting a ModuleInstance can really free up the objects that are associated with it
    @spoonincode
    spoonincode committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    2e2af40 View commit details
    Browse the repository at this point in the history

  2. Clean up wasm cache entries based on irreversiblity passing 

    previously wasm cache entries would remain indefinitely, becoming a sort of "memory leak". This is a naive change that cleans up entries once a replacement has occured and passed irreversiblity
    @spoonincode
    spoonincode committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    69ed139 View commit details
    Browse the repository at this point in the history