Add Integration Catchup Test #6989
Conversation
…for interacting with the test accounts.
tests/nodeos_startup_catchup.py
Outdated
| txnGenNodes.append(cluster.getNode(nodeNum)) | ||
|
|
||
| txnGenNodes[0].txnGenCreateTestAccounts(cluster.eosioAccount.name, cluster.eosioAccount.activePrivateKey) | ||
| time.sleep(20) |
There was a problem hiding this comment.
Can we verify they exist instead of just hoping they are there in 20 seconds?
tests/nodeos_startup_catchup.py
Outdated
| lastCatchupHeadNum=head(catchupNode) | ||
|
|
||
| catchupNode.interruptAndVerifyExitStatus(60) | ||
| retryCountMax*=3 |
tests/nodeos_startup_catchup.py
Outdated
| time.sleep(5) | ||
| retryCount+=1 | ||
| # give it some more time if the head is still moving forward | ||
| if retryCount>=100 or head(catchupNode)<=lastCatchupHeadNum: |
There was a problem hiding this comment.
Is this 100 suppose to be retryCountMax?
tests/nodeos_startup_catchup.py
Outdated
| lastHeadNum=head(node0) | ||
|
|
||
| catchupNode=cluster.getNodes()[-1] | ||
| time.sleep(9) |
There was a problem hiding this comment.
In general the fewer the sleeps the better. I want to avoid depending on sleep time to avoid this test failing on slower/faster machines. Also we are in the process of trying to speed up tests.
|
Had a conversation with @brianjohnson5972.
|
|
Talked with @heifner and need to add checking for transactions actually being generated. |
|
Implementation for #6727 |
Change Description
#6727
Added an integration test to expose a problem found in net_plugin where blocks were received out of order and the catching up node no longer received new blocks.
Consensus Changes
API Changes
Documentation Additions