This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[XC 10.2] Remove boost::thread usage from mongo plugin #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost::thread is problematic on some new compiler + old boost combos
spoonincode
commented
Mar 29, 2019
| @@ -292,15 +291,15 @@ bool mongo_db_plugin_impl::filter_include( const transaction& trx ) const | |||
|
|
|||
| template<typename Queue, typename Entry> | |||
| void mongo_db_plugin_impl::queue( Queue& queue, const Entry& e ) { | |||
| boost::mutex::scoped_lock lock( mtx ); | |||
| std::unique_lock<std::mutex> lock( mtx ); | |||
There was a problem hiding this comment.
This could use a double check
There was a problem hiding this comment.
std::lock_guard would be slightly better. But probably not worth pushing a new commit.
There was a problem hiding this comment.
I don't think std::lock_guard works here because the code then does things like lock.unlock(); -- unlock()/lock() isn't exposed by lock_guard AFAICT
There was a problem hiding this comment.
You are correct. I missed the unlock()/lock()
heifner
reviewed
Mar 29, 2019
| @@ -408,7 +407,7 @@ void mongo_db_plugin_impl::consume_blocks() { | |||
| _account_controls = mongo_conn[db_name][account_controls_col]; | |||
|
|
|||
| while (true) { | |||
| boost::mutex::scoped_lock lock(mtx); | |||
| std::unique_lock<std::mutex> lock(mtx); | |||
| while ( transaction_metadata_queue.empty() && | |||
There was a problem hiding this comment.
This could also be std::lock_guard, but again not worth changing unless you change the one above.
heifner
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
boost::thread is problematic on some new compiler + old boost combos
Consensus Changes
API Changes
Documentation Additions