This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[XC 10.2] chainbase sync - Remove boost thread include and locking support - 1.7 #7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
force-pushed
the
chainbase_remove_boost_thread_17x
branch
from
a57d443
to
ddbc338
Compare
spoonincode
changed the title
spoonincode
force-pushed
the
chainbase_remove_boost_thread_17x
branch
from
ddbc338
to
1b593e6
Compare
heifner
approved these changes
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
chainbase locking was removed from the develop/1.8 branch over a month ago because it was never used. Well, it was used in one single place: controller_impl::clear_all_undo(), but that was effectively a noop since nothing else used locking. Unfortunately to remove all remnants of boost mutexes (with problematic behavior on newer toolchains) this locking code needs to be removed from 1.7 too. Because this change has been in develop for over a month confidence of no side effects is high.
Consensus Changes
API Changes
Documentation Additions