This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Artifact check #7129
Merged
Artifact check #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tar process fails for the build directory at the end of a build, there is no current way to fail that step and not proceed on with other tests. This creates a major inefficiency: We can't simply restart the build step to try again as the tests have started and trying to pull an artifact that doesn't exist. We have to start a new pipeline run and all distros under it, wasting agents.
I've tested and added tests to be sure that the step fails if the tar doesn't exist and also opened up a feature request with buildkite to add this feature and avoid using the [ ! -f ] test.