This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
.buildkite Folder Updates Merged in from develop #7148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arhag
approved these changes
Apr 17, 2019
conr2d
pushed a commit
to Game-X-Coin/gxc
that referenced
this pull request
Apr 20, 2019
* Removed Buildkite pipelines which have been centralized * Buildkite: Merged in changes from eosio pipeline on develop * Case matters * BASH doesn't like exclamation points in quotes * Forgot these steps run in shell, not BASH * Why use quotes at all without variables when apostrophies exist * Migrated long-running tests from develop * Added .pipelinebranch to point to legacy-os for centralized pipelines * Disabled AWS-2 NP and LR tests * Git Submodule Regression Check requires a script 0_o
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This branch forked from develop on February 21st.
Since that fork, many important changes have been made to the Buildkite pipeline in
developwhere those authors neglected to PR those changes on other relevant branches, such as this one.This pull request migrates the current
/.buildkitefolder fromdeveloptorelease.1.7.x.Changes:
pipeline.ymlfrom develop/scripts/parallel-test.sh(see pull request 6963 for details)/scripts/serial-test.sh(see pull request 6963 for details)long_running_tests.ymlfrom develop/scripts/long-running-test.sh(see pull request 6963 for details)/.pipelinebranchpointing tolegacy-osso centralized repos test against deprecated operating systems on this branchLong-running tests tested in build 2556.
Amazon Linux 2
In the process of doing this, I have discovered Amazon Linux 2 steps have been disabled since February 20. They were disabled by Nathan in pull request 6733, then this branch was forked, then they were subsequently re-enabled on develop in pull request 6841 on February 25th.
I tried re-enabling the Amazon Linux 2 steps while working on this pull request. The build and parallel tests worked fine, but the non-parallelizable tests and long-running tests fail HARD.
See NP test failures in build 10690 here and here, and again in build 10693.
See LR test failures in build 2554.
Areg had me fork from the v1.7.0-rc1 tag to see if enabling the Amazon Linux 2 tests back then caused the same error in build 10704. They did, so we chose to leave the Amazon Linux 2 NP and LR tests disabled for this pull request because it was not a change on the release/1.7.x branch which caused this failure. We believe these are failures with the test framework itself rather than nodeos, given that all unit tests pass AND integration tests pass on all operating systems, including operating systems in the same Fedora family (Amazon Linux 1, CentOS 7, Fedora 27).
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.