This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix bugs in block_log #7188
Merged
Fix bugs in block_log #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; contruct_index should leave index file empty if block log contains no blocks
larryk85
approved these changes
Apr 23, 2019
heifner
approved these changes
Apr 23, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes two bugs in
block_log.First, it allows opening a non-empty block log that contains no blocks. This actually fixes undefined behavior that would lead to a segmentation fault when attempting to open a block log that contained no blocks.
Second, a check is added to
construct_indexto prevent an attempt to read a block when the block log is known to not contain any blocks. In this situation, instead of throwing an exception,construct_indexwill now correctly leave an empty index file.Consensus Changes
API Changes
Documentation Additions