This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Look in both lib and lib64 for CMake modules when building EOSIO Tester #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kj4ezj
changed the title
kj4ezj
changed the title
This was referenced May 11, 2019
larryk85
approved these changes
May 13, 2019
|
The sync tests are sick today, ignore that check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Currently, the CDT pipeline fails to build CDT in the presence of EOSIO on CentOS with integration tests because it can't find
libbuiltins. Previously, in pull request 7140, I had configured CMake to be able to find libraries in$HOME/opt/eosio/lib64/on CentOS. Unfortunately, CMake is still putting thelibbuiltins.afile in$HOME/opt/eosio/lib/during the EOSIO build, even though all other libraries are being put into$HOME/opt/eosio/lib64/.This pull request addresses this unexpected and undesirable behavior by configuring CMake to check both places for each individual file while building EOSIO tester, instead of expecting all files to be in one folder or the other.
Tested
eosio.cdt:release/1.6.xeosio.cdt:release/1.6.xeosio.cdt:developeosio.cdt:release/1.5.xSee Also
release/1.8.xdevelopConsensus Changes
None.
API Changes
None.
Documentation Additions
None.