This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
ship: uncompress when sending to clients #7383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
approved these changes
May 20, 2019
tbfleming
added a commit
that referenced
this pull request
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This change separates on-disk compression from on-socket compression. This helps to support the following in the future:
This change causes the first delta to bump past the exising 1GB limit in the on-socket protocol on partial history nodes. This is close to varuint32's 4GB limit. This PR upgrades the size prefix from a varuint32 to a varuint64 and removes the limit.
Related: #7381
Consensus Changes
API Changes
get_blocks_result_v0tracesanddeltasfields:Documentation Additions