This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix nodeos 1.8.x to > 1.7.x peering issue (allowed-connection not equal to "any") - 1.7.x #7699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7575
Note: My guess is this is less of an issue between eosio versions and more of an issue with different compiler tool chains. However, it is good to ensure all platforms use nanoseconds so they match up.
Change Description
Issue: #7575
The default std::chrono::duration resolution changed from nanoseconds in 1.7.x and below to microseconds in 1.8.x. When allowed-connection not equal to "any" the time skew between peers needs to be less than 1 sec. The time skew check will always fail due to the resolution mismatch.
Modifications:
added explicit cast of the current time to nanoseconds during the peering handshake intialization.
Consensus Changes
API Changes
Documentation Additions