This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add protocol feature CODE_VERSION #7835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
suggested changes
Dec 31, 2019
libraries/chain/wasm_interface.cpp
Outdated
| @@ -987,6 +987,13 @@ class authorization_api : public context_aware_api { | |||
| return context.is_account( account ); | |||
| } | |||
|
|
|||
| void get_code_version( const account_name& account, int64_t& last_code_update_time, fc::sha256& code_hash ) { | |||
There was a problem hiding this comment.
intrinsics with multiple output parameters have very strange semantics when the pointers alias. I would strongly recommend either using a packed struct or splitting this into two intrinsics.
| using namespace eosio; | ||
|
|
||
| void code_version_test::reqversion( name name, checksum256 version ) { | ||
| check( get_code_version(name) == version, "code version not match" ); |
There was a problem hiding this comment.
The error message is not grammatically correct.
| } | ||
|
|
||
| void code_version_test::reqtime( name name, time_point last_code_update ) { | ||
| check( get_code_last_update_time(name) == last_code_update, "last update time not match" ); |
|
|
||
| #include <eosio/eosio.hpp> | ||
|
|
||
| namespace eosio { |
There was a problem hiding this comment.
It's better not to put this stuff in namespace eosio, as that causes a headache when cdt is eventually updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fix #6168.
Consensus Changes
Consensus upgrade.
API Changes
New intrinsic API
get_code_versionis introduced by this PR.Documentation Additions
The documentation of eosio.cdt needs to include
get_code_version.