This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
bandwidth - 1.8.x #7836
Merged
bandwidth - 1.8.x #7836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct they are on a fork
heifner
added a commit
that referenced
this pull request
Sep 3, 2019
…related app post from low to medium since it deals with blocks.
b1bart
suggested changes
Sep 3, 2019
| req.req_blocks.mode = catch_up; | ||
| req.req_trx.mode = none; | ||
| c->enqueue( req ); | ||
| if( cc.get_block_id_for_num( msg.head_num ) != msg.head_id ) { |
There was a problem hiding this comment.
There is a comment block above where we should probably note what this branch "means"
Something like
4.1 My head block number >= peer head block number but they appear to be on a different fork which may be better and should be requested
There was a problem hiding this comment.
At the very least we should note the difference in comments in develop I think these backports also should bear the comments though.
There was a problem hiding this comment.
Good point. I'll update all of them.
b1bart
approved these changes
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
request_messagefor our head greater thanmsg.headwhen we suspect they are on a fork.Consensus Changes
API Changes
Documentation Additions