Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[1.7.x] Brew Updater Skips #7874

Merged
merged 4 commits into from
Sep 9, 2019
Merged

[1.7.x] Brew Updater Skips #7874

merged 4 commits into from
Sep 9, 2019

Conversation

scottarnette
Copy link
Contributor

@scottarnette scottarnette commented Sep 9, 2019

Change Description

Added fixes for the following CICD issues:

  • Removed de-duping logic from .cicd/generate-pipeline.sh. This prevented Linux distros from running on unpinned builds as no separate unpinned dockerfiles exist within the .cicd directory for 1.7.x. See: https://buildkite.com/EOSIO/eosio-build-unpinned/builds/517
    ** This also means that there is no difference between pinned and unpinned builds of 1.7.x based branches.
  • Removed leftover SKIP_MOJAVE flag in brew updater.
  • Removed leftover SKIP_HIGH_SIERRA flag in brew updater.
  • Fixed brew updater if statements to use same SKIPs as build/test steps: SKIP_MACOS_10_13 and SKIP_MACOS_10_14
    ** SKIP_MAC will now skip the step entirely while if statements will allow the appropriate brew updater step to run if a specific version is skipped.
    ** See SKIP issue here: https://buildkite.com/EOSIO/eosio/builds/16774

See:
https://buildkite.com/EOSIO/eosio/builds/17158 | Pinned
https://buildkite.com/EOSIO/eosio-build-unpinned/builds/520 | Unpinned

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@scottarnette scottarnette marked this pull request as ready for review September 9, 2019 18:34
@arhag arhag merged commit b4338fc into release/1.7.x Sep 9, 2019
@arhag arhag deleted the cicd-brew-updater-r1.7 branch September 9, 2019 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants