Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[1.7.x] Support all BK cases in Submodule Regression Script #7938

Merged
merged 2 commits into from
Sep 17, 2019
Merged

[1.7.x] Support all BK cases in Submodule Regression Script #7938

merged 2 commits into from
Sep 17, 2019

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented Sep 17, 2019 •
edited

Problems:

  1. When manually running a forked PR using pull/7924/head:develop-submodule-regression-fix, the script will fail to use the merged commit for that forked PR.
  2. git log logic wasn't working and throwing exit 1

Solutions:

  1. Support if the PR slug exists (it's a forked PR) by doing git fetch/checkout of the ghost/merged commit.
  2. Added no-pager and changed the logic to wrap in test

Buildkite

@NorseGaud NorseGaud mentioned this pull request Sep 17, 2019
Merged
@NorseGaud NorseGaud merged commit 934461d into release/1.7.x Sep 17, 2019
@NorseGaud NorseGaud deleted the 1.7.x-submodule-regression-script-fix branch September 17, 2019 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arhag arhag arhag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NorseGaud @arhag