This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
[1.8.x] Change submodule script to see stderr for git commands #8020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
@arhag noticed https://buildkite.com/EOSIO/eosio-build-unpinned/builds/672#5d95d3d3-5a60-4180-864a-8316b1840036 was failing, but it didn't say why. It's understandably confusing since it looks like agent lost or other agent/infra failures.
While I can't see the reason for the original failure, I can see that we hide STDERR with &> /dev/null. That's not good, so I'm going to change it to 1> /dev/null instead.
Consensus Changes
API Changes
Documentation Additions