Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Propagate exceptions out push_block - 1.8 #8386

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Propagate exceptions out push_block - 1.8 #8386

merged 1 commit into from
Jan 2, 2020

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Jan 2, 2020

Change Description

  • Propagate exceptions out of on_incoming_block push_block so net_plugin knows block was not applied.
  • Unapplied blocks were being recorded as applied causing net_plugin to be out of sync with the controller and not applying blocks as they were received.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner mentioned this pull request Jan 2, 2020
Merged
3 tasks
@larryk85 larryk85 merged commit b00197c into release/1.8.x Jan 2, 2020
@larryk85 larryk85 deleted the block-except-1.8 branch January 2, 2020 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larryk85 larryk85 larryk85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heifner @larryk85