Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Handle socket close before async callback - develop #8527

Merged
merged 1 commit into from Jan 29, 2020
Merged

Handle socket close before async callback - develop #8527

merged 1 commit into from Jan 29, 2020

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Jan 29, 2020

Change Description

  • Clean up internal state when socket closed before async callback otherwise net_plugin is confused on re-connect. Specifically, the handshake generation needs to be reset.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner
close() when socket close before callback so state can be cleaned up …
f39dd3d 
…otherwise net_plugin is confused on re-connect.
@heifner heifner merged commit 2ec9956 into develop Jan 29, 2020
@heifner heifner deleted the net-plugin-socket-close-dev branch January 29, 2020 21:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianjohnson5972 brianjohnson5972 brianjohnson5972 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heifner @brianjohnson5972