Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Exit transaction early when insufficient account cpu - 1.8 #8678

Merged
merged 26 commits into from
Feb 25, 2020
Merged

Exit transaction early when insufficient account cpu - 1.8 #8678

merged 26 commits into from
Feb 25, 2020

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Feb 22, 2020

Change Description

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner
Do not attempt to exec a trx if account cpu does not have sufficient …
563c059 
…cpu to execute according to last time trx was executed.
@heifner
Use tx_cpu_usage_exceeded instead of deadline exception
49f246e
@heifner
Add test for indication of cpu time stopping exec of trx
2958183
@heifner
Code cleanup to use is_producing_block() for validation check instead…
d6f2ed2 
… of explicit_billed_cpu_time
@heifner
Modify push_scheduled_transaction to have all non-default args to mat…
7d7cfed 
…ch push_transaction
@heifner
Factor in greylist_cpu_usage_exceeded & block_cpu_usage_exceeded alon…
a1c83d8 
…g with tx_cpu_usage_exceeded so correct exception thrown in early eval of previously billed cpu
@heifner
Evaluate block exhausted via timer instead of just looking at excepti…
432090e 
…on. Rename failure_is_subjective to block_is_exhausted to better reflect what the function does.
@heifner
Assert expected explicit_billed_cpu_time value
57de171
@heifner
Assert expected explicit_billed_cpu_time value
978d492
@heifner
Assert when limited cpu time to bill not equal to cpu time to bill
25f15dc
@heifner
Fix logic in validate_account_cpu_usage
2a16ce0
@heifner
Explicitly disallow greylisting when validating block
b3fa910
@heifner
Consolidate logic of validate_cpu_usage_to_bill & validate_account_cp…
e02e737 
…u_usage
@heifner
Allow explicit billing of 0
94323af
@heifner
Match logic of producer_plugin
e3a4f7b
@heifner
Use explicit billing for test since the test is not testing billing
f614394
@heifner
Make test clearer and add additional checks
866bfa8
@heifner
Move deadline check up
1050cd3
@heifner
Remove restriction on 0 billed cpu
9e25db8
@heifner
Use explicit billing in core tester to avoid timing issues'
610f20d
@heifner
Update tests to use correct account cpu limit and correct non-explici…
7380072 
…t billing
@heifner
Add test case for explicit billing over account cpu limit
853864b
@heifner
Update comments
54b36db
@heifner
Cleanup tests from peer review comments
6b10a4a
@heifner
Rename block_is_exhausted which was failure_is_subjective to execepti…
b558139 
…on_is_exhausted
@heifner
Do not set exhausted flag.
b9a09fc
johndebord
johndebord approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@johndebord johndebord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@heifner heifner merged commit dfedac5 into release/1.8.x Feb 25, 2020
@heifner heifner deleted the opt-cpu-check-1.8 branch February 25, 2020 23:46
@adsorptionenthalpy adsorptionenthalpy mentioned this pull request May 6, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianjohnson5972 brianjohnson5972 brianjohnson5972 approved these changes

@johndebord johndebord johndebord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heifner @brianjohnson5972 @johndebord