This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Produce block immediately if exhausted - 1.8 #8680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or max_block_net_usage) is reached.
…bytes. Factor them into block exhaustion via new block_is_exhausted() method
…n_async to avoid double call of timer when in start_block. Updated new option descriptions.
johndebord
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
cpu-effort-percent
to produce block ifmax_block_cpu_usage
ormax_block_net_usage
is reached. Produce block immediately upon exhaustion.a
in Block production documentation #8650 whencpu-effort-percent
is greater thanmax_block_cpu_usage
as the block will be produced whenmax_block_*_usage
is hit instead of waiting for thecpu-effort-percent
window to expire.Consensus Changes
API Changes
Documentation Additions
Documentation Additions
New configuration options:
max-block-cpu-usage-threshold-us
Threshold of CPU block production to consider block full; when within threshold of max-block-cpu-usage block can be produced immediately. Default value 5000.
max-block-net-usage-threshold-bytes
Threshold of NET block production to consider block full; when within threshold of max-block-net-usage block can be produced immediately. Default value 1024.