This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix mutliple version protocol test intermittent failure - 1.8 #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndcgundlach
approved these changes
Mar 2, 2020
heifner
deleted the
fix-multiple-version-protocol-intermittent-failure-1.8
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed error in test due to 1.7 version producer producing block just as next block starts it production window and thus rejecting that block, just as production for all producers is paused. Added logging to indicate producer is paused or resumed. Also other test cleanup and updated error message of forked_chain_test.
Consensus Changes
API Changes
Documentation Additions