Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix double titles in plugins #8842

Merged
merged 5 commits into from Mar 19, 2020
Merged

Fix double titles in plugins #8842

merged 5 commits into from Mar 19, 2020

Conversation

dixia
Copy link
Contributor

@dixia dixia commented Mar 18, 2020 •
edited by lparisc

Remove the title on each plugin pages

Sibling PR #8843 into develop
Depends on PR #8844

Change Description

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@dixia
remove the title
95c42a1 
remove the title
@dixia dixia requested review from lparisc and bobgt March 18, 2020 08:00
@dixia dixia changed the base branch from develop to release/2.0.x March 18, 2020 08:11
heifner
heifner suggested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for release/2.0.x then rebase to that branch. Otherwise target develop.

@lparisc lparisc changed the base branch from release/2.0.x to develop March 18, 2020 13:49
@lparisc lparisc changed the title Remove the double title Fix double titles in plugins Mar 18, 2020
@lparisc lparisc added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label Mar 18, 2020
Luis Paris and others added 4 commits March 18, 2020 12:12
Merge branch 'develop' into fix-titles
c9498f1
@dixia
Remove the double titles
36a2b83 
Remove the double titles
@dixia
Add index
4012454 
Add index for trace API
@dixia
Fix a typo
33fe7bd 
Fix a typo
@lparisc
Copy link
Contributor

lparisc commented Mar 18, 2020 •
edited

@heifner please unblock when you can - target branch was changed, commits made to sync w/ sibling PR #8843, and changes reviewed/approved.

@lparisc lparisc merged commit 38ab331 into develop Mar 19, 2020
@lparisc lparisc deleted the fix-titles branch March 19, 2020 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lparisc lparisc lparisc approved these changes

@heifner heifner heifner approved these changes

@iamveritas iamveritas iamveritas approved these changes

@bobgt bobgt Awaiting requested review from bobgt

Assignees

@dixia dixia

Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dixia @lparisc @heifner @iamveritas