Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix uninitialized struct members used as CLI flags - develop #9059

Merged
merged 1 commit into from May 7, 2020
Merged

Fix uninitialized struct members used as CLI flags - develop #9059

merged 1 commit into from May 7, 2020

Conversation

revl
Copy link
Contributor

@revl revl commented May 7, 2020

Change Description

This commit initializes uninitialized struct members used as CLI11 flags. Previously, only the local uninitialized variables were fixed, and struct fields were consciously omitted.

Fixes #9058

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@revl
Fix uninitialized struct members used as CLI flags
f59bd7c 
Previously, only the local uninitialized variables were fixed, and
struct fields were consciously omitted. Never assume. Always check. :-/

Fixes #9058
@revl revl mentioned this pull request May 7, 2020
Merged
3 tasks
@revl revl merged commit b1fca45 into develop May 7, 2020
@revl revl deleted the 9058-fix-unitialized-struct-members branch May 7, 2020 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@revl @heifner