This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
separate out signature provider from producer plugin #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryk85
suggested changes
May 8, 2020
larryk85
approved these changes
May 8, 2020
This was referenced Jun 25, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Currently the only time nodeos needs to perform a signature is when signing a block. Thus defining keys and where to find the private key for those keys has been in producer plugin.
Going forward though, this will not be the only use case for signing in nodeos. For example, a witness needs to sign blocks as well.
Move the signature provider code out of producer plugin to its own plugin so that any plugin can leverage signing through a single impl.
Consensus Changes
API Changes
Documentation Additions