Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Abi kv nodeos #9429

Merged
merged 10 commits into from Aug 25, 2020
Merged

Abi kv nodeos #9429

merged 10 commits into from Aug 25, 2020

Conversation

kimjh2005
Copy link
Contributor

@kimjh2005 kimjh2005 commented Aug 24, 2020

Change Description

The ABI Serializer is defined at libraries/chain/abi_serializer.cpp and various supporting headers.
https://blockone.atlassian.net/browse/EPE-209

-kv_tables defined in abi_def.
-custom to_variant() and from_variant() defined as the existing codes treat them as an array.
-added variant_to_binary and binary_to_add to abi_serializer.

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@kimjh2005 kimjh2005 marked this pull request as ready for review August 24, 2020 15:05
libraries/chain/abi_serializer.cpp Outdated Show resolved Hide resolved
libraries/chain/abi_serializer.cpp Outdated Show resolved Hide resolved
libraries/chain/abi_serializer.cpp Outdated Show resolved Hide resolved
libraries/chain/abi_serializer.cpp Outdated Show resolved Hide resolved
unittests/abi_tests.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dimas1185 dimas1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it now but suggest you to learn about SFINAE technique. that way you don't need this object at all.
with SFINAE you can define your to_variant/from_variant that way:
template<typename T, typename = enable_if_t<is_same_v<T, your_object_type>, void>> void from_variant(const fc::variant& v, eosio::chain::may_no_exist& o) {}

@kimjh2005 kimjh2005 merged commit e976c83 into develop Aug 25, 2020
@jeffreyssmith2nd jeffreyssmith2nd deleted the abi-kv-nodeos branch August 25, 2020 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants