This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
dimas1185
suggested changes
Aug 24, 2020
dimas1185
reviewed
Aug 24, 2020
heifner
reviewed
Aug 24, 2020
jeffreyssmith2nd
approved these changes
Aug 25, 2020
dimas1185
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve it now but suggest you to learn about SFINAE technique. that way you don't need this object at all.
with SFINAE you can define your to_variant/from_variant that way:
template<typename T, typename = enable_if_t<is_same_v<T, your_object_type>, void>> void from_variant(const fc::variant& v, eosio::chain::may_no_exist& o) {}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The ABI Serializer is defined at libraries/chain/abi_serializer.cpp and various supporting headers.
https://blockone.atlassian.net/browse/EPE-209
-kv_tables defined in abi_def.
-custom to_variant() and from_variant() defined as the existing codes treat them as an array.
-added variant_to_binary and binary_to_add to abi_serializer.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions