Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add error output when ABI is not generated using "eosio-cpp" #1037

Merged
merged 7 commits into from Feb 1, 2021

Conversation

bogniq
Copy link
Collaborator

@bogniq bogniq commented Jan 22, 2021

Change Description

When using eosio-cpp to generate WASM and ABI, if the contract is empty, or if the specified contract name doesn't match the real contract name, the ABI will silently not be generated. This fix adds warning output, or throws exception with error messages, for this situation.

Notes:

  • Only when --abigen option is set, the warning or error is output. This is to avoid incompatibility with some previous code (e.g. some contracts in the unit test code have different names for contract and filename). This decision can be further discussed.
  • The specified contract name is either explicitly specified by --contract, or inferred from output name by -o, or the same as the contract filename if neither '--contract' or '-o' is set.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@nksanthosh nksanthosh merged commit 4a449fc into release/1.8.x Feb 1, 2021
@bogniq bogniq deleted the qy_abi_not_generated_error_1.8.x branch February 2, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants