Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

REX enhancements and bug fixes #182

Merged
merged 27 commits into from
Feb 7, 2019
Merged

REX enhancements and bug fixes #182

merged 27 commits into from
Feb 7, 2019

Conversation

zorba80
Copy link
Contributor

@zorba80 zorba80 commented Jan 31, 2019

Change Description

  1. Fixed rounding error bug in sellrex.
  2. Fixed bug that allows rex balance to go negative in case a sell order is queued.
  3. Fixed bug in REX vote weight. voteproducer now uses the updated REX vote_stake.
  4. Deleted require_recipient from proxy voting.
  5. Changed rex_pool initial total_rent balance from 100k EOS to 20k EOS, in order to lower initial renting cost.
  6. Increased lower bound of rex_pool total_unlent balance.
  7. Added inline dummy actions to buyrex, unstaketorex, and sellrex. This results in action outcome to show up in action trace.

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes
  1. Deleted require_recipient from proxy voting.
  2. Added actions mvtosavings and mvfrsavings.

Documentation Additions

  • Documentation Additions

kj4ezj and others added 24 commits January 3, 2019 15:30
Other: Created pull request template
Add functionality to explicitly manage account resources
The tester instance should be configured to not push its bios contract 
at startup since the unit test is going to push its own bios contract. 
Previously, if both bios contracts happened to be identical, the test 
would fail due to a duplicate transaction.
Fix eosio_system_tests/setabi_bios test
@@ -581,6 +634,38 @@ namespace eosiosystem {
double shares_rate, bool reset_to_zero = false );
double update_total_votepay_share( time_point ct,
double additional_shares_delta = 0.0, double shares_rate_delta = 0.0 );

template <auto system_contract::*...Ptrs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, who ever wrote this is amazing!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's VT PhD level coding. :)

@zorba80 zorba80 merged commit 5087727 into release/1.6.x Feb 7, 2019
@zorba80 zorba80 deleted the rex-en branch February 11, 2019 15:16
@thbourlove
Copy link

why deleted require_recipient from proxy voting? it will cause proxy won't be notified after user update votes.

vlbos pushed a commit to vlbos/bos.contracts that referenced this pull request Nov 26, 2019
REX enhancements and bug fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants