This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other: Created pull request template
Add functionality to explicitly manage account resources
The tester instance should be configured to not push its bios contract at startup since the unit test is going to push its own bios contract. Previously, if both bios contracts happened to be identical, the test would fail due to a duplicate transaction.
Fix eosio_system_tests/setabi_bios test
larryk85
reviewed
Feb 5, 2019
@@ -581,6 +634,38 @@ namespace eosiosystem { | |||
double shares_rate, bool reset_to_zero = false ); | |||
double update_total_votepay_share( time_point ct, | |||
double additional_shares_delta = 0.0, double shares_rate_delta = 0.0 ); | |||
|
|||
template <auto system_contract::*...Ptrs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, who ever wrote this is amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's VT PhD level coding. :)
larryk85
approved these changes
Feb 6, 2019
why deleted require_recipient from proxy voting? it will cause proxy won't be notified after user update votes. |
vlbos
pushed a commit
to vlbos/bos.contracts
that referenced
this pull request
Nov 26, 2019
REX enhancements and bug fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Deployment Changes
API Changes
mvtosavings
andmvfrsavings
.Documentation Additions