This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Simplify and Refactor RAM Market Equations #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
exchange_state
functionsconvert_to_exchange
andconvert_from_exchange
to reflect directly the equations in Bancor white paper.get_bancor_output
fromexchange_state
in order to avoid code repetition.convert_to_exchange
andconvert_from_exchange
functions when used individually were not an accurate implementation of the Bancor equations in the white paper, but when used together, the variations cancelled and the overall output is the same. We verified that both mathematically and in unit tests.Deployment Changes
API Changes
Documentation Additions