Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Rentbw Results No-op Inline Action #518

Closed
wants to merge 3 commits into from

Conversation

deckb
Copy link
Contributor

@deckb deckb commented Sep 10, 2020

Change Description

Addition of REX-like inline action for fee and rental information of rentbw action

Deployment Changes

  • Deployment Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Documentation for rentbw should be updated to reflect thatrentbw.results.abi ABI should be deployed to the eosio.reserv account, but that the corresponding WASM contract should not be deployed to eosio.reserv (for efficiency reasons).

Copy link
Contributor

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I'm not sure how we want to handle versioning and whether it should be merged into rentbw-1.9 or another branch (to avoid changing the code associated with links already handed out in public).

Also, the rentbw documentation will eventually need to be updated to reflect the new deployment expectations. Particularly, that the rentbw.results.abi ABI should be deployed to the eosio.reserv account, but that the corresponding WASM contract should not be deployed to eosio.reserv (for efficiency reasons).

@deckb
Copy link
Contributor Author

deckb commented Dec 9, 2020

This has been handled elsewhere.

@deckb deckb closed this Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants