This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Get block header fallback #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbfleming
reviewed
Aug 30, 2019
src/eosjs-api.ts
Outdated
|
|
||
| const taposBlockNumber = info.head_block_num - blocksBehind; | ||
| let refBlock: GetBlockHeaderStateResult | GetBlockResult; | ||
| if (taposBlockNumber - info.last_irreversible_block_num < 2) { |
There was a problem hiding this comment.
There's a race condition. If this is false now, it may be true when nodeos processes the get_block_header_state request. If that fails, it needs to retry with get_block.
There was a problem hiding this comment.
I'll just wrap in a try/catch instead of trying to predict when this error will occur then.
tbfleming
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In response to #584
API Changes
The previous PR actually introduced the API changes, but the changes should be backwards compatible for any consumers of the API. This PR will add a fallback which will fix certain cases where
get_block_header_statewill failDocumentation Additions