This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Resolving issue with encoding argument (release/21.0.x) #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Encoding with hashing methods is currently broken. If you add the encoding argument to the sign/recover/verify methods, the data will be blanked out by
hash.jsas the encoding argument is not a part of that library. Adjusting code to use encoding before hashing by creating a Buffer from the data with the encoding if the data is a string.Resolves #781
Second PR to cherry pick commits to release/21.0.x branch
API Changes
Documentation Additions